Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No ws condition in create cmd #143

Merged

Conversation

chriscarnold
Copy link
Contributor

@chriscarnold chriscarnold commented Oct 29, 2023

Checklist:

  • I have read and followed the contribution guideline.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have tested these changes and added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • 100% unit test coverage achieved

(Documentation change doesn't seem necessary)

Related Issue

Closing: #113
DEM-128

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)

Description

Fixes whitespaces in Development Environment names. Adds validation in the create_dev_env() function in create_cmd.py. If a name with whitespace is provided, an error message is displayed, and the creation is aborted. Added test function in test_create_cmd.py to make sure that the function does not proceed to retrieve an existing Development Environment if the name contains whitespace. It also tests if the error message is displayed.

How Has This Been Tested?

Tested locally. Passed all unit tests in test_create_cmd.py before test_create_dev_env_with_whitespace() was added and passed all tests after.

Screenshots (if appropriate):

image

@chriscarnold chriscarnold requested a review from a team as a code owner October 29, 2023 16:21
@janosmurai janosmurai added the hacktoberfest-accepted Accepted during hacktoberfest label Oct 30, 2023
@janosmurai janosmurai merged commit fa8f8a0 into axem-solutions:main Oct 30, 2023
1 check passed
@janosmurai
Copy link
Contributor

Nice job! Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted during hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants