feat: accept any Dev Env descriptor. #141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the test_DevEnv () function in test_dev_end.py file. This is not needed since the _check_tool_type_support () function has been removed from the dev_env.py file to allow for all tool types.
|
Hi, Could you review the pull request for both commits |
janosmurai
requested changes
Oct 27, 2023
There was a problem hiding this comment.
We still need the test_DevEnv() function as it is responsible for checking the correct instantiation.
Please delete the test_DevEnv__check_tool_type_support() instead, as you removed the _check_tool_type_support() function.
Restored test_DevEnv() function since its required for checking correct instantiation and deleted test_DevEnv_check_tool_type_support() function because it's not needed after removing the _check_tool_type_support() function in the
janosmurai
approved these changes
Oct 27, 2023
janosmurai
requested changes
Oct 27, 2023
Removed all reference to _check_tool_type_support as well as all @patch.object and mock__check_tool_type_support
…tor-1 Update test_dev_env.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Related Issue
Closing:
Type Of Change
Description
How Has This Been Tested?
Screenshots (if appropriate):
Additional context