Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different environment variable for instance setup #6

Closed
wants to merge 19 commits into from
Closed

Use different environment variable for instance setup #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
6da4112
use different environment variable for instance setup
subhojit777 Mar 16, 2022
7d93ad0
parametrize instance name
subhojit777 Mar 25, 2022
655f4fc
update var name aligning it with platform.sh
subhojit777 Mar 31, 2022
099c0d5
debug: see if now the name appears
subhojit777 Mar 31, 2022
cb8ee2c
hat: see if this works
subhojit777 Mar 31, 2022
08e15d1
hat: mention that it is github env
subhojit777 Mar 31, 2022
d66e4d6
hat: simply specify the env var
subhojit777 Mar 31, 2022
134196a
hat: try using step output
subhojit777 Mar 31, 2022
e23c211
pass shell option
subhojit777 Mar 31, 2022
ad07cd3
debug: see if it is indeed setting the step output
subhojit777 Apr 6, 2022
0f1d4c1
debug: if env vars are available
subhojit777 Apr 6, 2022
5d6e503
hat: see if this sets the output value
subhojit777 Apr 6, 2022
379fc49
hat: see if this resolves the issue
subhojit777 Apr 6, 2022
8319c82
hat: see if this resolves unexpected symbol issue
subhojit777 Apr 6, 2022
dae7c77
hat: see if this resolves the GH var
subhojit777 Apr 6, 2022
b234867
add empty check condition while setting the var
subhojit777 Apr 6, 2022
d9830c8
fix the way the var is assigned
subhojit777 Apr 6, 2022
9aabc98
debug: steps
subhojit777 Apr 6, 2022
7aaa5b3
refer the correct step name
subhojit777 Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ inputs:
force-push:
description: 'Force push to Platform.sh'
required: false
environment-name:
description: 'Name of the platform.sh instance'
required: false
runs:
using: "composite"
steps:
Expand All @@ -29,13 +32,22 @@ runs:
- uses: adam7/[email protected]
with:
token: ${{ inputs.cli-token }}
-
name: Set environment name
id: set_environment_name
shell: bash
run: |
ENVIRONMENT_NAME=${{ inputs.environment-name }}
[[ "$ENVIRONMENT_NAME" == "" ]] && ENVIRONMENT_NAME="$GITHUB_REF_NAME"
echo "::set-output name=url::$ENVIRONMENT_NAME"
Comment on lines +35 to +42
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not very fond of this. I think we can handle this in the shell script itself quite robustly. See my other two suggestions.

Comment on lines +35 to +42
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-
name: Set environment name
id: set_environment_name
shell: bash
run: |
ENVIRONMENT_NAME=${{ inputs.environment-name }}
[[ "$ENVIRONMENT_NAME" == "" ]] && ENVIRONMENT_NAME="$GITHUB_REF_NAME"
echo "::set-output name=url::$ENVIRONMENT_NAME"

- run: ${{ github.action_path }}/deploy.sh
shell: bash
env:
SSH_PRIVATE_KEY: ${{ inputs.ssh-private-key }}
PLATFORM_PROJECT_ID: ${{ inputs.project-id }}
PLATFORMSH_CLI_TOKEN: ${{ inputs.cli-token }}
FORCE_PUSH: ${{ inputs.force-push }}
ENVIRONMENT_NAME: ${{ steps.set_environment_name.outputs.url }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ENVIRONMENT_NAME: ${{ steps.set_environment_name.outputs.url }}
ENVIRONMENT_NAME: ${{ inputs.environment-name }}

branding:
icon: upload-cloud
color: orange
2 changes: 1 addition & 1 deletion deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ mkdir -p ~/.ssh && chmod 0700 ~/.ssh
cat ${GITHUB_ACTION_PATH}/known_hosts >> ~/.ssh/known_hosts

platform project:set-remote ${PLATFORM_PROJECT_ID}
PLATFORM_OPTS="-vv --activate --target ${GITHUB_REF_NAME}"
PLATFORM_OPTS="-vv --activate --target $ENVIRONMENT_NAME"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PLATFORM_OPTS="-vv --activate --target $ENVIRONMENT_NAME"
[[ "$ENVIRONMENT_NAME" == "" ]] && ENVIRONMENT_NAME="$GITHUB_REF_NAME"
PLATFORM_OPTS="-vv --activate --target $ENVIRONMENT_NAME"

if [[ -n "$FORCE_PUSH" ]]; then
PLATFORM_OPTS="$PLATFORM_OPTS --force"
fi
Expand Down