Use different environment variable for instance setup #6
Conversation
|
@hussainweb @skippednote Can you please take a look. |
|
The problem is that We should explore making this an input parameter. That way, the calling job can set the branch to whatever they want. By default, we could use |
|
@hussainweb Agree. Makes sense. I will take a look. |
|
@hussainweb This can be reviewed now. |
| @@ -11,7 +11,7 @@ mkdir -p ~/.ssh && chmod 0700 ~/.ssh | |||
| cat ${GITHUB_ACTION_PATH}/known_hosts >> ~/.ssh/known_hosts | |||
|
|
|||
| platform project:set-remote ${PLATFORM_PROJECT_ID} | |||
| PLATFORM_OPTS="-vv --activate --target ${GITHUB_REF_NAME}" | |||
| PLATFORM_OPTS="-vv --activate --target $ENVIRONMENT_NAME" | |||
There was a problem hiding this comment.
| PLATFORM_OPTS="-vv --activate --target $ENVIRONMENT_NAME" | |
| [[ "$ENVIRONMENT_NAME" == "" ]] && ENVIRONMENT_NAME="$GITHUB_REF_NAME" | |
| PLATFORM_OPTS="-vv --activate --target $ENVIRONMENT_NAME" |
| - | ||
| name: Set environment name | ||
| id: set_environment_name | ||
| shell: bash | ||
| run: | | ||
| ENVIRONMENT_NAME=${{ inputs.environment-name }} | ||
| [[ "$ENVIRONMENT_NAME" == "" ]] && ENVIRONMENT_NAME="$GITHUB_REF_NAME" | ||
| echo "::set-output name=url::$ENVIRONMENT_NAME" |
There was a problem hiding this comment.
I am not very fond of this. I think we can handle this in the shell script itself quite robustly. See my other two suggestions.
| - run: ${{ github.action_path }}/deploy.sh | ||
| shell: bash | ||
| env: | ||
| SSH_PRIVATE_KEY: ${{ inputs.ssh-private-key }} | ||
| PLATFORM_PROJECT_ID: ${{ inputs.project-id }} | ||
| PLATFORMSH_CLI_TOKEN: ${{ inputs.cli-token }} | ||
| FORCE_PUSH: ${{ inputs.force-push }} | ||
| ENVIRONMENT_NAME: ${{ steps.set_environment_name.outputs.url }} |
There was a problem hiding this comment.
| ENVIRONMENT_NAME: ${{ steps.set_environment_name.outputs.url }} | |
| ENVIRONMENT_NAME: ${{ inputs.environment-name }} |
| - | ||
| name: Set environment name | ||
| id: set_environment_name | ||
| shell: bash | ||
| run: | | ||
| ENVIRONMENT_NAME=${{ inputs.environment-name }} | ||
| [[ "$ENVIRONMENT_NAME" == "" ]] && ENVIRONMENT_NAME="$GITHUB_REF_NAME" | ||
| echo "::set-output name=url::$ENVIRONMENT_NAME" |
There was a problem hiding this comment.
| - | |
| name: Set environment name | |
| id: set_environment_name | |
| shell: bash | |
| run: | | |
| ENVIRONMENT_NAME=${{ inputs.environment-name }} | |
| [[ "$ENVIRONMENT_NAME" == "" ]] && ENVIRONMENT_NAME="$GITHUB_REF_NAME" | |
| echo "::set-output name=url::$ENVIRONMENT_NAME" |
Fixes #5