feat: rename deployTokenManager to linkToken and change the message type for deploying remote token managers #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
==========================================
- Coverage 99.18% 98.11% -1.08%
==========================================
Files 20 20
Lines 738 743 +5
Branches 170 171 +1
==========================================
- Hits 732 729 -3
- Misses 6 14 +8 ☔ View full report in Codecov by Sentry. |
milapsheth
reviewed
Jan 9, 2025
| if (!success) revert GatewayCallFailed(returnData); | ||
| } | ||
|
|
||
| function linkToken( |
There was a problem hiding this comment.
Mention that for EVM destination, linkParams is just the token manager operator address as bytes
contracts/InterchainTokenService.sol
Outdated
| // Custom token managers can't be deployed with native interchain token type, which is reserved for interchain tokens | ||
| if (tokenManagerType == TokenManagerType.NATIVE_INTERCHAIN_TOKEN) revert CannotDeploy(tokenManagerType); | ||
|
|
||
| address deployer = msg.sender; | ||
|
|
||
| if (deployer == interchainTokenFactory) { | ||
| if (msg.sender == interchainTokenFactory) { |
There was a problem hiding this comment.
Suggested change
| if (msg.sender == interchainTokenFactory) { | |
| if (deployer == interchainTokenFactory) { |
There was a problem hiding this comment.
you changed that in the original PR and I was wondering why.
contracts/InterchainTokenService.sol
Outdated
| bytes32 tokenId, | ||
| string calldata destinationChain, | ||
| uint256 gasValue, | ||
| bytes memory destinationTokenAddress, |
There was a problem hiding this comment.
Suggested change
| bytes memory destinationTokenAddress, | |
| bytes calldata destinationTokenAddress, |
contracts/InterchainTokenService.sol
Outdated
| TokenManagerType tokenManagerType, | ||
| bytes calldata params | ||
| bytes memory params, |
There was a problem hiding this comment.
Suggested change
| bytes memory params, | |
| bytes calldata params, |
contracts/InterchainTokenService.sol
Outdated
| @@ -944,13 +968,17 @@ contract InterchainTokenService is | |||
| _callContract(destinationChain, payload, IGatewayCaller.MetadataVersion.CONTRACT_CALL, gasValue); | |||
| } | |||
|
|
|||
| /** | |||
| /* | |||
There was a problem hiding this comment.
Suggested change
| /* | |
| /** |
removed accidentally?
| * @param tokenManagerType The type of token manager. Cannot be NATIVE_INTERCHAIN_TOKEN. | ||
| * @param params The deployment parameters. | ||
| * @param linkParams The link parameters. |
There was a problem hiding this comment.
mention that note on operator being linkParams for EVM case
Co-authored-by: Milap Sheth <[email protected]>
Co-authored-by: Milap Sheth <[email protected]>
Co-authored-by: Milap Sheth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXE-7068