feat: added automatic token migration #317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milapsheth
reviewed
Jan 7, 2025
Comment on lines
38
to
39
| /// @dev Track the flow amount being received via the message | ||
| ITokenManager(tokenManager).addFlowIn(amount); |
There was a problem hiding this comment.
Suggested change
| /// @dev Track the flow amount being received via the message | |
| ITokenManager(tokenManager).addFlowIn(amount); | |
| _migrateToken(tokenManager, tokenAddress, tokenManagerType); | |
| /// @dev Track the flow amount being received via the message | |
| ITokenManager(tokenManager).addFlowIn(amount); |
call migrate separately so it's cleaner, gas cost difference should be very small
There was a problem hiding this comment.
you mean call it for every token type? indiscriminately? This would revert if the token in question does not implement isMinter
| @@ -172,4 +178,10 @@ contract TokenHandler is ITokenHandler, ITokenManagerType, ReentrancyGuard, Crea | |||
| function _burnTokenFrom(address tokenAddress, address from, uint256 amount) internal { | |||
| IERC20(tokenAddress).safeCall(abi.encodeWithSelector(IERC20BurnableFrom.burnFrom.selector, from, amount)); | |||
| } | |||
|
|
|||
| function _migrateToken(address tokenManager, address tokenAddress) internal { | |||
There was a problem hiding this comment.
add a docstring to explain this auto migration feature
contracts/TokenHandler.sol
Outdated
| tokenManagerType == uint256(TokenManagerType.NATIVE_INTERCHAIN_TOKEN) || tokenManagerType == uint256(TokenManagerType.MINT_BURN) | ||
| ) { | ||
| if (tokenManagerType == uint256(TokenManagerType.NATIVE_INTERCHAIN_TOKEN)) { | ||
| _migrateToken(tokenManager, tokenAddress); |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/manual-migrate-tokens #317 +/- ##
==============================================================
- Coverage 99.18% 99.06% -0.13%
==============================================================
Files 20 20
Lines 740 746 +6
Branches 175 174 -1
==============================================================
+ Hits 734 739 +5
- Misses 6 7 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXE-7066