-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(its): allow its owner to manually migrate tokens #316
Open
Foivos
wants to merge
6
commits into
feat/token-manager-mint-interchain-tokens-2
Choose a base branch
from
feat/manual-migrate-tokens
base: feat/token-manager-mint-interchain-tokens-2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8e0c290
Added some functions to migrate tokens
Foivos 4c7e551
Merge branch 'feat/token-manager-mint-interchain-tokens-2' into feat/…
milapsheth a833844
Update contracts/InterchainTokenService.sol
Foivos 123c9c1
removed migrate legacy token and added tests
Foivos 716fb46
made lint happy
Foivos e4f3152
Merge branch 'feat/token-manager-mint-interchain-tokens-2' into feat/…
Foivos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,7 @@ import { IInterchainTokenExecutable } from './interfaces/IInterchainTokenExecuta | |
import { IInterchainTokenExpressExecutable } from './interfaces/IInterchainTokenExpressExecutable.sol'; | ||
import { ITokenManager } from './interfaces/ITokenManager.sol'; | ||
import { IGatewayCaller } from './interfaces/IGatewayCaller.sol'; | ||
import { IMinter } from './interfaces/IMinter.sol'; | ||
import { Create3AddressFixed } from './utils/Create3AddressFixed.sol'; | ||
import { Operator } from './utils/Operator.sol'; | ||
|
||
|
@@ -643,6 +644,16 @@ contract InterchainTokenService is | |
} | ||
} | ||
|
||
/** | ||
* @notice Allows the owner to migrate minter of native interchain tokens from ITS to the corresponding token manager. | ||
* @param tokenId the tokenId of the registered token. | ||
*/ | ||
function migrateInterchainToken(bytes32 tokenId) external onlyOwner { | ||
ITokenManager tokenManager_ = deployedTokenManager(tokenId); | ||
address tokenAddress = tokenManager_.tokenAddress(); | ||
IMinter(tokenAddress).transferMintership(address(tokenManager_)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for unit test, also test failure when migrating an already migrated token There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added all tests, please check |
||
} | ||
|
||
/****************\ | ||
INTERNAL FUNCTIONS | ||
\****************/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing JIRA ticket