Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: addressed ackee's report #312

Merged
merged 16 commits into from
Jan 6, 2025
Merged

feat: addressed ackee's report #312

merged 16 commits into from
Jan 6, 2025

Conversation

Foivos
Copy link
Contributor

@Foivos Foivos commented Dec 10, 2024

No description provided.

@Foivos Foivos requested a review from a team as a code owner December 10, 2024 17:04
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.18%. Comparing base (a7439cd) to head (eb4c928).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
contracts/InterchainTokenFactory.sol 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
- Coverage   99.44%   99.18%   -0.27%     
==========================================
  Files          20       20              
  Lines         724      738      +14     
  Branches      170      170              
==========================================
+ Hits          720      732      +12     
- Misses          4        6       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

contracts/InterchainTokenFactory.sol Outdated Show resolved Hide resolved
contracts/InterchainTokenService.sol Outdated Show resolved Hide resolved
contracts/TokenHandler.sol Show resolved Hide resolved
test/InterchainToken.js Outdated Show resolved Hide resolved
contracts/interchain-token/InterchainToken.sol Outdated Show resolved Hide resolved
test/TokenManager.js Outdated Show resolved Hide resolved
test/InterchainTokenFactory.js Outdated Show resolved Hide resolved
test/InterchainToken.js Outdated Show resolved Hide resolved
@milapsheth milapsheth enabled auto-merge (squash) January 6, 2025 15:42
@milapsheth milapsheth merged commit d38f107 into main Jan 6, 2025
5 checks passed
@milapsheth milapsheth deleted the feat/achee-report-29-11-24 branch January 6, 2025 15:43
milapsheth added a commit that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants