feat(its): add custom token support with auto scaling #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foivos
approved these changes
Dec 10, 2024
contracts/InterchainTokenService.sol
Outdated
| tokenId = linkToken(salt, destinationChain, destinationTokenAddress.toBytes(), tokenManagerType, false, linkParams, gasValue); | ||
| } | ||
|
|
||
| function linkToken(bytes32 salt, string calldata destinationChain, bytes memory destinationTokenAddress, TokenManagerType tokenManagerType, bool autoScaling, bytes memory linkParams, uint256 gasValue) public payable whenNotPaused returns (bytes32 tokenId) { |
There was a problem hiding this comment.
If this is to be used for local deployments too then linkToken is confusing.
| // Restricted on ITS contracts deployed to Amplifier chains until ITS Hub adds support | ||
| revert NotSupported(); | ||
| } else if (bytes(destinationChain).length == 0) { | ||
| // TODO: Only support linking new tokens via ITS factory, to include chain name in token id derivation |
There was a problem hiding this comment.
What happens to already deployed custom tokens?
| } | ||
|
|
||
| tokenId = interchainTokenId(deployer, salt); | ||
|
|
||
| emit InterchainTokenIdClaimed(tokenId, deployer, salt); | ||
|
|
||
| if (bytes(destinationChain).length == 0) { | ||
| _deployTokenManager(tokenId, tokenManagerType, params); | ||
| _deployTokenManager(tokenId, tokenManagerType, destinationTokenAddress.toAddress(), linkParams); |
There was a problem hiding this comment.
linkParams are just the operator for local deployments it seems.
Foivos
reviewed
Dec 10, 2024
| ); | ||
|
|
||
| if (tokenManagerType == TokenManagerType.NATIVE_INTERCHAIN_TOKEN) revert CannotDeploy(tokenManagerType); | ||
|
|
||
| _deployTokenManager(tokenId, tokenManagerType, params); | ||
| _deployTokenManager(tokenId, tokenManagerType, destinationTokenAddress.toAddress(), linkParams); |
There was a problem hiding this comment.
I think even if the only param left in EVM is the operator, we should have it be abi encoded when it is passed as params.
milapsheth
commented
Dec 10, 2024
milapsheth
force-pushed
the
feat/link-tokens
branch
from
937dd92 to
6d65c01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deployTokenManagerto reduce ITS bytecode after tests are updated to uselinkTokenTwo new message types are introduced:
RegisterTokenMetadata: Sends a message to ITS hub to register token decimals by token addressLinkToken: Allows linking custom tokens across chains. LinkToken needs to be submitted from the same origin chain to other remote chains for the sametokenId. Existing custom tokens can still be linked by callinglinkTokenfrom a chain that has a registered token for thattokenId.