fix(its): remove unnecessary use of payable in functions

[ahramy]

AXE-4706

• I tested all functions with use of payable. To verify, I removed payable and ran unit tests one by one.

InterchainTokenFactory.sol

[x] deployInterchainToken -> MulticallFailed, unit test failed
[x] deployRemoteInterchainToken -> MulticallFailed, unit test failed
[x] registerCanonicalInterchainToken -> MulticallFailed, TakeTokenFailed, unit test failed
[x] deployRemoteCanonicalInterchainToken -> MulticallFailed, unit test failed

TokenHandler.sol

[o] giveToken -> payable can be removed.
[x] takeToken -> lockUnlockFee failed
[o] transferTokenFrom -> payable can be removed.
[x] postTokenManagerDeploy -> PostDeployFailed

InterchainTokenService.sol

[x] deployTokenManager -> failed
[x] deployInterchainToken -> Cannot set option "value" on a non-payable function type.
[x] expressExecute
[x] interchainTransfer -> MultiCallFailed, non-payable method cannot override value
[o] callContractWithInterchainToken -> payable can be removed.
=> Not sure we should remove it. Are we allowing ETH to be sent or not?
=> Unit test should be added.

TransmitInterchainToken.sol

[x] transmitInterchainTransfer -> Cannot set option "value" on a non-payable function type.

InterchainTokenStandard.sol

[x] interchainTransfer -> "msg.value" and "callvalue()" can only be used in payable public functions.
[x] interchainTransferFrom -> "msg.value" and "callvalue()" can only be used in payable public functions.

GatewayCaller.sol

[x] callContract -> GatewayCallFailed

TokenManagerDeployer

[x] deployTokenManager -> TokenManagerDeploymentFailed

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.79%. Comparing base (c58ed5e) to head (4eb655d).
Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
+ Coverage   97.67%   97.79%   +0.12%     
==========================================
  Files          19       19              
  Lines         601      545      -56     
  Branches      126      120       -6     
==========================================
- Hits          587      533      -54     
+ Misses          5        4       -1     
+ Partials        9        8       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Foivos]

You cannot call non payable functions in multical, which is why the payable is needed on all these functions.