Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
milapsheth authored Jan 10, 2025
1 parent 5bcb97a commit 2a606ec
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .changeset/many-tigers-kneel.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
'@axelar-network/interchain-token-service': minor
---

Interchain tokens now get minted/burnt by the token manager.
Interchain tokens now get minted/burnt by the token manager to be consistent with custom tokens
4 changes: 2 additions & 2 deletions contracts/TokenHandler.sol
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@ contract TokenHandler is ITokenHandler, ITokenManagerType, ReentrancyGuard, Crea
*/
// slither-disable-next-line locked-ether
function postTokenManagerDeploy(uint256 tokenManagerType, ITokenManager tokenManager) external payable {
// For native interhcain tokens we transfer mintership to the token manager.
// This is done here because InterchainToken bytecode needs to be fixed.
// For native interchain tokens, we transfer mintership to the token manager.
// This is done here because the InterchainToken bytecode is preferred to be fixed to avoid having multiple versions of the Token code used in production.
if (tokenManagerType == uint256(TokenManagerType.NATIVE_INTERCHAIN_TOKEN)) {
IMinter(tokenManager.tokenAddress()).transferMintership(address(tokenManager));
// For lock/unlock token managers, the ITS contract needs an approval from the token manager to transfer tokens on its behalf.
Expand Down

0 comments on commit 2a606ec

Please sign in to comment.