updated

axelarnetwork · Nov 11, 2024 · 22c9676 · 22c9676
1 parent dde32a9
commit 22c9676
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 8 deletions.
diff --git a/contracts/InterchainTokenFactory.sol b/contracts/InterchainTokenFactory.sol
@@ -104,7 +104,7 @@ contract InterchainTokenFactory is IInterchainTokenFactory, ITokenManagerType, M
     /**
      * @notice Deploys a new interchain token with specified parameters.
      * @dev Creates a new token and optionally mints an initial amount to a specified minter.
-     * The function is marked as `payable` to enable multi-call execution.
+     * The function is `payable` because non-payable functions cannot be called in a multi-call context.
      * @param salt The unique salt for deploying the token.
      * @param name The name of the token.
      * @param symbol The symbol of the token.
@@ -155,7 +155,6 @@ contract InterchainTokenFactory is IInterchainTokenFactory, ITokenManagerType, M
 
     /**
      * @notice Deploys a remote interchain token on a specified destination chain.
-     * @dev The function is marked as `payable` to enable multi-call execution.
      * @param salt The unique salt for deploying the token.
      * @param minter The address to receive the minter and operator role of the token, in addition to ITS. If the address is `address(0)`,
      * no additional minter is set on the token. Reverts if the minter does not have mint permission for the token.
@@ -252,7 +251,7 @@ contract InterchainTokenFactory is IInterchainTokenFactory, ITokenManagerType, M
 
     /**
      * @notice Registers a canonical token as an interchain token and deploys its token manager.
-     * @dev The function is marked as `payable` to enable multi-call execution.
+     * The function is `payable` because non-payable functions cannot be called in a multi-call context.
      * @param tokenAddress The address of the canonical token.
      * @return tokenId The tokenId corresponding to the registered canonical token.
      */
@@ -265,7 +264,6 @@ contract InterchainTokenFactory is IInterchainTokenFactory, ITokenManagerType, M
 
     /**
      * @notice Deploys a canonical interchain token on a remote chain.
-     * @dev The function is marked as `payable` to enable multi-call execution.
      * @param originalTokenAddress The address of the original token on the original chain.
      * @param destinationChain The name of the chain where the token will be deployed.
      * @param gasValue The gas amount to be sent for deployment.

diff --git a/contracts/InterchainTokenService.sol b/contracts/InterchainTokenService.sol
@@ -382,6 +382,7 @@ contract InterchainTokenService is
 
     /**
      * @notice Express executes operations based on the payload and selector.
+     * @dev The function is `payable` because non-payable functions cannot be called in a multi-call context.
      * @param commandId The unique message id.
      * @param sourceChain The chain where the transaction originates from.
      * @param sourceAddress The address of the remote ITS where the transaction originates from.
@@ -477,7 +478,6 @@ contract InterchainTokenService is
     /**
      * @notice Initiates an interchain transfer of a specified token to a destination chain.
      * @dev The function retrieves the TokenManager associated with the tokenId.
-     * The function is marked as `payable` to enable multi-call execution.
      * @param tokenId The unique identifier of the token to be transferred.
      * @param destinationChain The destination chain to send the tokens to.
      * @param destinationAddress The address on the destination chain to send the tokens to.

diff --git a/contracts/TokenHandler.sol b/contracts/TokenHandler.sol
@@ -31,7 +31,6 @@ contract TokenHandler is ITokenHandler, ITokenManagerType, ReentrancyGuard, Crea
      * @return uint256 The amount of token actually given, which could be different for certain token type.
      * @return address the address of the token.
      */
-    // slither-disable-next-line locked-ether
     function giveToken(bytes32 tokenId, address to, uint256 amount) external returns (uint256, address) {
         address tokenManager = _create3Address(tokenId);
 
@@ -107,7 +106,6 @@ contract TokenHandler is ITokenHandler, ITokenManagerType, ReentrancyGuard, Crea
      * @return uint256 The amount of token actually transferred, which could be different for certain token type.
      * @return address The address of the token corresponding to the input tokenId.
      */
-    // slither-disable-next-line locked-ether
     function transferTokenFrom(bytes32 tokenId, address from, address to, uint256 amount) external returns (uint256, address) {
         address tokenManager = _create3Address(tokenId);
         (uint256 tokenManagerType, address tokenAddress) = ITokenManagerProxy(tokenManager).getImplementationTypeAndTokenAddress();

diff --git a/contracts/interfaces/ITokenHandler.sol b/contracts/interfaces/ITokenHandler.sol
@@ -40,7 +40,6 @@ interface ITokenHandler {
      * @return uint256 The amount of token actually transferred, which could be different for certain token type.
      * @return address The address of the token corresponding to the input tokenId.
      */
-    // slither-disable-next-line locked-ether
     function transferTokenFrom(bytes32 tokenId, address from, address to, uint256 amount) external returns (uint256, address);
 
     /**