chore: remove unused saveGMP API

axelarnetwork · Jan 12, 2024 · 12f2b7c · 12f2b7c
1 parent 83210e7
commit 12f2b7c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 71 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [0.13.10] - 2024-JANUARY-12
+
+- Remove unused internal APIs
+
 ## [0.13.8] - 2023-DECEMBER-18
 
 - Add `Immutable` to mainnet configs; update `Immutable` testnet RPC

diff --git a/src/libs/TransactionRecoveryApi/AxelarGMPRecoveryAPI.ts b/src/libs/TransactionRecoveryApi/AxelarGMPRecoveryAPI.ts
@@ -172,25 +172,6 @@ export class AxelarGMPRecoveryAPI extends AxelarRecoveryApi {
     });
   }
 
-  private async saveGMP(
-    sourceTransactionHash: string,
-    relayerAddress: string,
-    sourceTransactionIndex?: number,
-    sourceTransactionLogIndex?: number,
-    transactionHash?: string,
-    error?: any
-  ) {
-    return await this.execPost(super.getAxelarGMPApiUrl, "", {
-      method: "saveGMP",
-      sourceTransactionHash,
-      transactionHash,
-      sourceTransactionIndex,
-      sourceTransactionLogIndex,
-      relayerAddress,
-      error,
-    });
-  }
-
   public getCidFromSrcTxHash(destChainId: string, txHash: string, eventIndex: number) {
     return getCommandId(destChainId, txHash, eventIndex, this.environment, rpcInfo);
   }
@@ -1147,28 +1128,6 @@ export class AxelarGMPRecoveryAPI extends AxelarRecoveryApi {
         }
       });
 
-    // Submit execute data to axelarscan if the contract execution is success.
-    const signerAddress = await signer.getAddress();
-    const executeTxHash = txResult.transaction?.transactionHash;
-    if (executeTxHash) {
-      await this.saveGMP(
-        srcTxHash,
-        signerAddress,
-        srcTxInfo.transactionIndex,
-        srcTxInfo.logIndex,
-        executeTxHash
-      ).catch(() => undefined);
-    } else {
-      await this.saveGMP(
-        srcTxHash,
-        signerAddress,
-        srcTxInfo.transactionIndex,
-        srcTxInfo.logIndex,
-        "",
-        txResult.error
-      ).catch(() => undefined);
-    }
-
     return txResult;
   }
 

diff --git a/src/libs/test/TransactionRecoveryAPI/AxelarGMPRecoveryAPI.spec.ts b/src/libs/test/TransactionRecoveryAPI/AxelarGMPRecoveryAPI.spec.ts
@@ -1525,23 +1525,11 @@ describe("AxelarGMPRecoveryAPI", () => {
       const error = new Error(ContractCallHelper.CALL_EXECUTE_ERROR.REVERT);
       vitest.spyOn(ContractCallHelper, "callExecute").mockRejectedValueOnce(error);
 
-      // Mock private saveGMP
-      const mockGMPApi = vitest.spyOn(AxelarGMPRecoveryAPI.prototype as any, "saveGMP");
-      mockGMPApi.mockImplementation(() => Promise.resolve(undefined));
-
       const sourceTxHash = "0x86e5f91eff5a8a815e90449ca32e02781508f3b94620bbdf521f2ba07c41d9ae";
       const response = await api.execute(sourceTxHash, undefined, evmWalletDetails);
 
       // Expect returns error
       expect(response).toEqual(ExecutionRevertedError(executeParams));
-
-      // Expect we don't call saveGMP api
-      expect(mockGMPApi).toHaveBeenCalledWith(
-        sourceTxHash,
-        new ethers.Wallet(evmWalletDetails.privateKey as string).address,
-        "",
-        response.error
-      );
     });
 
     test("it calls 'execute' and return revert error given 'callExecute' throws 'CALL_EXECUTE_ERROR.INSUFFICIENT_FUNDS' error", async () => {
@@ -1557,23 +1545,11 @@ describe("AxelarGMPRecoveryAPI", () => {
       const error = new Error(ContractCallHelper.CALL_EXECUTE_ERROR.INSUFFICIENT_FUNDS);
       vitest.spyOn(ContractCallHelper, "callExecute").mockRejectedValueOnce(error);
 
-      // Mock private saveGMP
-      const mockGMPApi = vitest.spyOn(AxelarGMPRecoveryAPI.prototype as any, "saveGMP");
-      mockGMPApi.mockImplementation(() => Promise.resolve(undefined));
-
       const sourceTxHash = "0x86e5f91eff5a8a815e90449ca32e02781508f3b94620bbdf521f2ba07c41d9ae";
       const response = await api.execute(sourceTxHash, undefined, evmWalletDetails);
 
       // Expect returns error
       expect(response).toEqual(InsufficientFundsError(executeParams));
-
-      // Expect we don't call saveGMP api
-      expect(mockGMPApi).toHaveBeenCalledWith(
-        sourceTxHash,
-        new ethers.Wallet(evmWalletDetails.privateKey as string).address,
-        "",
-        response.error
-      );
     });
 
     test("it should call 'execute' and return success = true", async () => {
@@ -1588,10 +1564,6 @@ describe("AxelarGMPRecoveryAPI", () => {
       // Mock contract call is successful
       vitest.spyOn(ContractCallHelper, "callExecute").mockResolvedValueOnce(contractReceiptStub());
 
-      // Mock private saveGMP
-      const mockGMPApi = vitest.spyOn(AxelarGMPRecoveryAPI.prototype as any, "saveGMP");
-      mockGMPApi.mockImplementation(() => Promise.resolve(undefined));
-
       const response = await api.execute(
         "0x86e5f91eff5a8a815e90449ca32e02781508f3b94620bbdf521f2ba07c41d9ae",
         undefined,
@@ -1624,8 +1596,6 @@ describe("AxelarGMPRecoveryAPI", () => {
           },
         },
       });
-
-      expect(mockGMPApi).toHaveBeenCalledTimes(1);
     });
   });
 });