Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-utils): return error if BroadcastTx fails #2124

Merged
merged 7 commits into from
Apr 4, 2024

Conversation

ilyalukyanov
Copy link
Contributor

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

@ilyalukyanov ilyalukyanov requested a review from a team as a code owner March 18, 2024 09:52
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.21%. Comparing base (8aba6e5) to head (e070d4f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2124      +/-   ##
==========================================
+ Coverage   48.05%   48.21%   +0.16%     
==========================================
  Files         263      263              
  Lines       15922    15928       +6     
==========================================
+ Hits         7651     7680      +29     
+ Misses       7682     7659      -23     
  Partials      589      589              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgorenflo cgorenflo enabled auto-merge (squash) April 3, 2024 22:15
@cgorenflo cgorenflo merged commit 1199688 into main Apr 4, 2024
8 of 9 checks passed
@cgorenflo cgorenflo deleted the fix/return-error-when-broadcast-fails branch April 4, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants