Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cosmwasm): remove requirement to use chainName option for AxelarnetGateway instantiation #472

Merged
merged 8 commits into from
Dec 18, 2024
Merged

fix(cosmwasm): remove requirement to use chainName option for AxelarnetGateway instantiation #472

merged 8 commits into from
Dec 18, 2024

Conversation

eguajardo
Copy link
Contributor

This fixes the issue of saving the address under AxelarnetGateway.axelar.address instead of just AxelarnetGateway.address

@eguajardo eguajardo requested a review from a team as a code owner December 12, 2024 18:00
milapsheth
milapsheth reviewed Dec 15, 2024
View reviewed changes
cosmwasm/utils.js Outdated Show resolved Hide resolved
cosmwasm/utils.js Outdated Show resolved Hide resolved
jcs47
jcs47 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@jcs47 jcs47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

@eguajardo eguajardo merged commit 8e184cc into main Dec 18, 2024
6 checks passed
@eguajardo eguajardo deleted the fix/axelarnetgateway-chainconfig branch December 18, 2024 15:30
@eguajardo eguajardo mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milapsheth milapsheth milapsheth left review comments

@talalashraf talalashraf talalashraf approved these changes

@jcs47 jcs47 jcs47 approved these changes

@canhtrinh canhtrinh Awaiting requested review from canhtrinh canhtrinh is a code owner automatically assigned from axelarnetwork/chainops

@sdaveas sdaveas Awaiting requested review from sdaveas sdaveas is a code owner automatically assigned from axelarnetwork/chainops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eguajardo @jcs47 @talalashraf @milapsheth