Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add agETH token #127

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

galacticminter
Copy link
Contributor

Adding Kelp's agETH config to whitelist on ITS.

Copy link
Contributor

@Olanetsoft Olanetsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galacticminter, kindly add your logo/icon.

@galacticminter
Copy link
Contributor Author

Hi @Olanetsoft, am I able to call these tokens on L2s as axl_agETH ? Is that convention fine ?

@Olanetsoft
Copy link
Contributor

Hi @Olanetsoft, am I able to call these tokens on L2s as axl_agETH ? Is that convention fine ?

Any reason for doing this?

@galacticminter
Copy link
Contributor Author

galacticminter commented Sep 18, 2024

We have a canonical token called agETH or wagETH on these L2s. Wouldn't want axelar tokens to be called with the same name. @Olanetsoft

@Olanetsoft
Copy link
Contributor

We have a canonical token called agETH or wagETH on these L2s. Wouldn't want axelar tokens to be called with the same name. @Olanetsoft

@galacticminter I see. You can't rename the token agETH on a chain, i see that's what its registered as here. You won't be able to change the chain name on the chain itself. ERC20s don't support something like a changeName function.

Alternatively, if you have a UI, you can map the proposed name to the name on-chain, e.g., `"agETH": "axl_agETH," so that any time someone tries to load agETH, you can show on your UI the axl-prefixed name.

@galacticminter
Copy link
Contributor Author

Sounds good @Olanetsoft

Could you please approve & merge this?

@Olanetsoft
Copy link
Contributor

Olanetsoft commented Sep 20, 2024

@galacticminter, one last thing. Could you please add your coingecko id ? eg. "coinGeckoId": "your-id".

See this reference

@ecdsafu
Copy link
Collaborator

ecdsafu commented Sep 22, 2024

@galacticminter on the Squid front end they'll be displayed using a prettySymbol, that we can edit as you like. Please let me know the preferred symbol on each chain

Copy link
Collaborator

@ecdsafu ecdsafu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@galacticminter
Copy link
Contributor Author

Please use the pretty symbol as axl_agETH

@ecdsafu
Copy link
Collaborator

ecdsafu commented Sep 23, 2024

Please use the pretty symbol as axl_agETH

Sounds good. In Squid we are switching to the standard agETH.axl is that ok with you? We think it reads much better and is consistent with other bridge notations, such as USDC.e for ESDU bridged from ethereum native bridge

@canhtrinh
Copy link
Collaborator

Please use the pretty symbol as axl_agETH

Sounds good. In Squid we are switching to the standard agETH.axl is that ok with you? We think it reads much better and is consistent with other bridge notations, such as USDC.e for ESDU bridged from ethereum native bridge

@ecdsafu - Jake from our BD team confirmed with theirs that your proposal is okay. Do you need to reflect that symbol here or do you have a separate mapping elsewhere that does that? If the latter, I will merge this PR rn

@Olanetsoft
Copy link
Contributor

Please use the pretty symbol as axl_agETH

Sounds good. In Squid we are switching to the standard agETH.axl is that ok with you? We think it reads much better and is consistent with other bridge notations, such as USDC.e for ESDU bridged from ethereum native bridge

@ecdsafu - Jake from our BD team confirmed with theirs that your proposal is okay. Do you need to reflect that symbol here or do you have a separate mapping elsewhere that does that? If the latter, I will merge this PR rn

Friendly bump @ecdsafu ^

Copy link
Collaborator

@ecdsafu ecdsafu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the prettySymbol to be agETH.axl and then we can merge and release

@canhtrinh canhtrinh merged commit 0724cf2 into axelarnetwork:main Sep 24, 2024
2 checks passed
NiftyAndy pushed a commit to NiftyLeague/axelar-configs that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants