add MSS token #123
Closed
add MSS token #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canhtrinh
reviewed
Sep 17, 2024
| "axelarChainId": "binance", | ||
| "tokenAddress": "0xf0F14CbD7ce6753BC209EB0d8F67fC84cccB9B2F", | ||
| "tokenManager": "0xB9d897478bf9adeb1e74E8a5BF3596786A25a6F0", | ||
| "tokenManagerType": "mintBurnFrom" |
There was a problem hiding this comment.
Any color on why this was deployed as mintBurnFrom instead of mintBurn? cc @benjamin852
canhtrinh
reviewed
Sep 17, 2024
| "axelarChainId": "base", | ||
| "tokenAddress": "0x4b556f3a476b58be7F35DF77EdD68FbE5076F706", | ||
| "tokenManager": "0xB9d897478bf9adeb1e74E8a5BF3596786A25a6F0", | ||
| "tokenManagerType": "mintBurnFrom" |
ecdsafu
approved these changes
Sep 22, 2024
|
closing this PR for now until more clarity on the |
|
Hi Axelar team. This is a custom token, and I did not build in the ability to have the "token manager" contract burn tokens from any address, so could not use the "mintBurn" implementation. As far as I know, the "mintBurnFrom" works identical, with the exception that the user needs to approve the token spending (so they can be burnt). It is all 100% operational mintstakeshare.com/bridge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not use the wizard since we did a custom deployment of the token managers, with a custom token on both chains, we are unable to register to ITS portal.
I looked at the other examples and believe I got our MSS token setup correctly