-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add MSS token #123
add MSS token #123
Conversation
"axelarChainId": "binance", | ||
"tokenAddress": "0xf0F14CbD7ce6753BC209EB0d8F67fC84cccB9B2F", | ||
"tokenManager": "0xB9d897478bf9adeb1e74E8a5BF3596786A25a6F0", | ||
"tokenManagerType": "mintBurnFrom" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any color on why this was deployed as mintBurnFrom
instead of mintBurn
? cc @benjamin852
"axelarChainId": "base", | ||
"tokenAddress": "0x4b556f3a476b58be7F35DF77EdD68FbE5076F706", | ||
"tokenManager": "0xB9d897478bf9adeb1e74E8a5BF3596786A25a6F0", | ||
"tokenManagerType": "mintBurnFrom" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same Q
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
icon and coingecko look good
closing this PR for now until more clarity on the |
Hi Axelar team. This is a custom token, and I did not build in the ability to have the "token manager" contract burn tokens from any address, so could not use the "mintBurn" implementation. As far as I know, the "mintBurnFrom" works identical, with the exception that the user needs to approve the token spending (so they can be burnt). It is all 100% operational mintstakeshare.com/bridge |
I could not use the wizard since we did a custom deployment of the token managers, with a custom token on both chains, we are unable to register to ITS portal.
I looked at the other examples and believe I got our MSS token setup correctly