Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: new structure with json schema validation #1

Merged
merged 73 commits into from
Aug 22, 2023

Conversation

alanrsoares
Copy link
Contributor

@alanrsoares alanrsoares commented Aug 10, 2023

  • define zod schemas for evm and cosmos chain configs
  • codegen scripts for json-schema based on zod schemas
  • add sample configs for both evm and cosmos chains
  • draft cli for generating configs
  • validation scripts
  • gh actions validation checks
  • complete cli functionality

@canhtrinh
Copy link
Collaborator

thanks, great work! a few comments:

  1. still needs some kind of mapping that maps file name -> chain id. i.e. goerli -> '5'.
  2. can the files just be called chainName.json instead of chainName.chain.json?
  3. ideally (actually), it would be great if we had a single json file with a full list of all the json files inputted by users above. i.e. users can generate their own inputs, but upon pull request, a new list is autogenerated via codegen combining all those individual files.
  4. can you add an ITS example? i saw the json schema validation and want to ensure it matches this proposed structure we agreed with the Squid team (at least for the assets): https://www.notion.so/bright-ambert-2bd/New-asset-chain-config-proposal-c0133643733f4fd19401b0006a5bcac8?pvs=4

we can talk next week on these comments?

@alanrsoares alanrsoares requested a review from npty August 14, 2023 03:09
@alanrsoares alanrsoares force-pushed the refactor/restructure-configs branch 2 times, most recently from 1ae09a5 to a0e9329 Compare August 20, 2023 23:03
@canhtrinh canhtrinh merged commit 0e4e029 into main Aug 22, 2023
1 check passed
@alanrsoares alanrsoares deleted the refactor/restructure-configs branch October 18, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants