Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bautajs-express-example, bautajs-fastify-example): add service to showcase request cancellation #72

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

Xavier-Redondo
Copy link
Contributor

@Xavier-Redondo Xavier-Redondo commented Jan 31, 2023

PR Checklist

  • I have added/updated documentation for any new behavior.

PR Description

This does not solve anything by itself but it is a previous/helpful step to try to solve the issue #65.

Basically we have added a new endpoint to both fastify and express example services:

  • service GET api/cancel/{number}
    • if number is less than 10: the endpoint waits that number of seconds and returns a string.
    • if number is greater than 10: the endpoint will wait 10 seconds and will cancel the request at that moment.

This showcases request cancellations inside bauta pipelines and provides a playground for issue #65.


fix(bautajs-fastify-example): add service example

this is to showcase the cancellation of requests
Copy link
Contributor

@franher franher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franher franher merged commit c4d431f into 3.x Jan 31, 2023
@franher franher deleted the feat/pcancelable-abort-controller branch January 31, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants