Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combined update #4

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

combined update #4

wants to merge 32 commits into from

Conversation

figadore
Copy link

@figadore figadore commented Apr 7, 2016

  • added tests
  • refactors to comply with rfc7231
  • updated readme
  • bumped version to 2.0.0

@awwright
Copy link
Owner

awwright commented Apr 8, 2016

Wow, give me a little bit to review this

@awwright
Copy link
Owner

awwright commented Apr 8, 2016

What's the purpose of renaming to content-type.js?

@figadore
Copy link
Author

figadore commented Apr 8, 2016

I'm not sure, that was done by @deoxxa. I can revert that change, for consistency with the package name

floatdrop and others added 3 commits April 8, 2016 14:22
* `select` tests test strings rather than MediaTypes
* added some tests for string splitting
@figadore
Copy link
Author

figadore commented Apr 14, 2016

wait, select was supposed to return a MediaType object, right?

@awwright
Copy link
Owner

@shinymayhem It looks like it'll return whatever was provided to the first argument that matches. That's by design iirc, and I might even rely on that behavior.

@figadore
Copy link
Author

figadore commented Apr 18, 2016

I'm not sure exactly what that means. From what I can tell, it ran mediaCmp on each element in the array for both arguments, and mediaCmp depends on the type property existing for its arguments.

https://github.com/Acubed/contenttype/blob/7022d0e567f8c9558ba4d58ea15391bc94bdc0a1/contenttype.js#L124

Let me know if I should update something

@awwright
Copy link
Owner

Your pull request is much appreciated, but this contains a lot of updates all at once. I'd like to break down into a number of smaller pull requests. I'll cherry-pick what I can, but idk if I can merge in all the stuff I'd like because of all the renaming and formatting changes that take place.

Changing the indent style is particularly problematic, anything after this causes a merge conflict I have to resolve. On the topic of indents, I personally use 3-space indents. That you can't accommodate everyone's indent preferences is one of the big reasons for tabs: http://lea.verou.me/2012/01/why-tabs-are-clearly-superior/

Are there any features you need right now or could use right away?

@figadore
Copy link
Author

figadore commented May 23, 2016

Good point about the tabs. I just submitted PR #5, which only includes changes related to parsing media types. Is this close to what you had in mind as far as smaller, mergeable pull requests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants