-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
combined update #4
base: master
Are you sure you want to change the base?
Conversation
figadore
commented
Apr 7, 2016
- added tests
- refactors to comply with rfc7231
- updated readme
- bumped version to 2.0.0
Wow, give me a little bit to review this |
What's the purpose of renaming to |
I'm not sure, that was done by @deoxxa. I can revert that change, for consistency with the package name |
* `select` tests test strings rather than MediaTypes * added some tests for string splitting
wait, |
@shinymayhem It looks like it'll return whatever was provided to the first argument that matches. That's by design iirc, and I might even rely on that behavior. |
I'm not sure exactly what that means. From what I can tell, it ran Let me know if I should update something |
Your pull request is much appreciated, but this contains a lot of updates all at once. I'd like to break down into a number of smaller pull requests. I'll cherry-pick what I can, but idk if I can merge in all the stuff I'd like because of all the renaming and formatting changes that take place. Changing the indent style is particularly problematic, anything after this causes a merge conflict I have to resolve. On the topic of indents, I personally use 3-space indents. That you can't accommodate everyone's indent preferences is one of the big reasons for tabs: http://lea.verou.me/2012/01/why-tabs-are-clearly-superior/ Are there any features you need right now or could use right away? |
Good point about the tabs. I just submitted PR #5, which only includes changes related to parsing media types. Is this close to what you had in mind as far as smaller, mergeable pull requests? |