Fix bug in update getting started guide workflow #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a bug in the update getting started guide workflow when assertions are disabled. This change also fixes a bug where '--verbose' executed git diff command in interactive mode. Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
fix-update-getting-started-guide-workflow
branch
from
a583fd5
to
7252bc3
Compare
austinvazquez
added
github_actions
sondavidb
approved these changes
Jun 4, 2024
Kern--
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Found via testing for #1248
When running in verbose mode, git diff is ran in interactive mode which blocked execution of the script. Additionally when assert mode is disabled, the script failed to exit properly.
Description of changes:
This change fixes a bug in the update getting started guide workflow when assertions are disabled. This change also fixes a bug where
--verboseexecuted git diff command in interactive mode.Testing performed:
Successfully ran locally:
bash scripts/update-getting-started-guide.sh --verbose 0.7bash scripts/update-getting-started-guide.sh --assert 0.8By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.