fix: remove unless api key of graphql which will break deployment by cfn

awslabs · Oct 28, 2021 · 0b94049 · 0b94049
1 parent ec3fa6e
commit 0b94049
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 14 deletions.
diff --git a/src/lib/dashboard-stack.ts b/src/lib/dashboard-stack.ts
@@ -90,7 +90,6 @@ import {
   CustomResource,
   CfnMapping,
   Aws,
-  Expiration,
   Fn,
   Resource,
   Stack,
@@ -365,14 +364,6 @@ export class TransactionDashboardStack extends NestedStack {
         defaultAuthorization: {
           authorizationType: AuthorizationType.IAM,
         },
-        additionalAuthorizationModes: [
-          {
-            authorizationType: AuthorizationType.API_KEY,
-            apiKeyConfig: {
-              expires: Expiration.after(Duration.days(30)),
-            },
-          },
-        ],
       },
       xrayEnabled: true,
     });

diff --git a/test/dashboard-stack.test.ts b/test/dashboard-stack.test.ts
@@ -295,11 +295,6 @@ describe('dashboard stack test suite', () => {
 
     expect(stack).toHaveResourceLike('AWS::AppSync::GraphQLApi', {
       AuthenticationType: 'AWS_IAM',
-      AdditionalAuthenticationProviders: [
-        {
-          AuthenticationType: 'API_KEY',
-        },
-      ],
       LogConfig: {
         CloudWatchLogsRoleArn: {
           'Fn::GetAtt': [
@@ -378,6 +373,10 @@ describe('dashboard stack test suite', () => {
     });
   });
 
+  test('no ApiKey of dashboard graphql is created', () => {
+    expect(stack).toCountResources('AWS::AppSync::ApiKey', 0);
+  });
+
   test('transaction generator is created', () => {
     expect(stack).toHaveResourceLike('AWS::Lambda::Function', {
       Environment: {