Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support china regions #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

qqshfox
Copy link

@qqshfox qqshfox commented Feb 12, 2020

Description of changes:

  • Replace hardcoded partition with AWS::Partition
  • Add bucket mappings.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mrcoronel
Copy link
Contributor

Hi @qqshfox , thanks for your pull request. Unfortunately, the buckets are already taken so I can't accept. If you'd like, you can change them to snapshots-tool-rds-cn-north-1-official snapshots-tool-rds-cn-northwest-1-official and I'll be happy to merge.

Thanks!

@qqshfox
Copy link
Author

qqshfox commented Feb 13, 2020 via email

@mrcoronel
Copy link
Contributor

I could try to create them again if you delete them from your account. But there is no guarantee someone else will take them

@qqshfox
Copy link
Author

qqshfox commented Feb 13, 2020

Deleted.

@mrcoronel
Copy link
Contributor

Thanks! I've got the buckets in my account now. I'll need to change a few things to upload the lambda code in these buckets, I'll merge the PR once that's ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants