-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support to create backup out of automated backups #53
base: master
Are you sure you want to change the base?
Conversation
@mrcoronel please help me review it |
92f7460
to
fe156eb
Compare
Copying automated backup doesn't work in case of encrypted DB. You need to manually add lambda's IAM role as the KMS key administrator to get this working. |
@nishant3794 It works for encrypted backups as well. Tested on aurora but doesn't work on mssql. I've opened a ticket with aWS also, but no information from them yet. To make it work on mssql, give KMS Grants permission to your lambda role. That's it. But if encryption is set via option group eg. TDE on mssql, you can't share snapshot with any other AWS account. This is a hard limit from aws. |
@smeena667 Doesn't work for postgres as well. Got "KMSKeyNotAccessibleFault". |
mind sharing your kms key policy? |
I got it working earlier by adding lambda's role to KMS key policy so it's all well now. |
I would add permissions to lambda role as lambda role name keep on changing on every cf deploy and using wildcard is not safe. In the CF, you can edit lambda role permissions and this way all following lambda functions will use the same permission. |
I believe that's better than my way!! Will do that. Thanks..
|
Description of changes:
UseAutomatedBackup
Why?
In some databases eg. ms sql server, during backup process, brief IO suspension happen. This change help reduce burden from live db instances and create backups from automated backups instead.
Similar PR is filed for aurora-snapshot-tool