Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passthrough mount options #970

Closed
wants to merge 2 commits into from
Closed

Add support for passthrough mount options #970

wants to merge 2 commits into from

Conversation

arsh
Copy link
Contributor

@arsh arsh commented Aug 5, 2024

Description of change

Add support for passthrough mount options. For example, this allows mounting on a non empty directory by specifying --mount-options nonempty.

Relevant issues: #954

Does this change impact existing behavior?

No.

Does this change need a changelog entry in any of the crates?

Yes and it is done.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@arsh arsh temporarily deployed to PR integration tests August 5, 2024 09:08 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests August 5, 2024 09:08 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests August 5, 2024 09:08 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests August 5, 2024 09:08 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests August 5, 2024 09:08 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests August 5, 2024 09:08 — with GitHub Actions Inactive
@arsh arsh temporarily deployed to PR integration tests August 5, 2024 09:08 — with GitHub Actions Inactive
@arsh arsh requested a review from jamesbornholt August 5, 2024 09:25
@arsh
Copy link
Contributor Author

arsh commented Aug 5, 2024

We decided not to go this route and explore adding a nonempty explicit option instead. Discarding this!

@arsh arsh closed this Aug 5, 2024
@arsh arsh removed the request for review from jamesbornholt August 5, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant