Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up process credentials provider support #350

Closed
wants to merge 1 commit into from

Conversation

monthonk
Copy link
Contributor

@monthonk monthonk commented Jul 3, 2023

Description of change

Update aws-c-auth dependency to version 0.6.30 which add process credentials provider in default chain.

Relevant issues: #326

Does this change impact existing behavior?

No, just add a new feature.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@monthonk monthonk temporarily deployed to PR integration tests July 3, 2023 09:19 — with GitHub Actions Inactive
@monthonk monthonk temporarily deployed to PR integration tests July 3, 2023 09:19 — with GitHub Actions Inactive
@monthonk monthonk temporarily deployed to PR integration tests July 3, 2023 09:19 — with GitHub Actions Inactive
@monthonk monthonk temporarily deployed to PR integration tests July 3, 2023 09:19 — with GitHub Actions Inactive
@dannycjones dannycjones self-requested a review July 3, 2023 09:25
Copy link
Contributor

@dannycjones dannycjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a little bit of manual testing, and the credential_process option is not working with my local machine. I'll do a bit more digging to understand what's going wrong.

@dannycjones dannycjones marked this pull request as draft July 3, 2023 12:10
@monthonk monthonk closed this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants