Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly prevent mounting over an existing mount #348

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Explicitly prevent mounting over an existing mount #348

merged 1 commit into from
Jun 30, 2023

Commits on Jun 30, 2023

  1. Explicitly prevent mounting over an existing mount 

    It's valid to mount multiple file systems to the same directory, but
doing so requires the first one to be mounted read-write, which is why
this wasn't a problem for us until awslabs#327. It seems libfuse2's version of
fusermount explicitly checked this(?), but libfuse3 no longer rejects
it.

In principle this might be something we'd want to allow, but I think the
less surprising/error-prone customer experience is to refuse to do it,
so let's explicitly forbid it.

Signed-off-by: James Bornholt <[email protected]>
    @jamesbornholt
    jamesbornholt committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    486c145 View commit details
    Browse the repository at this point in the history