Retrieve server-side encryption setting on HeadObject #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Passaro <[email protected]>
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
Signed-off-by: Alessandro Passaro <[email protected]>
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
previously approved these changes
Nov 19, 2024
vladem
previously approved these changes
Nov 19, 2024
| let key = format!("{prefix}hello"); | ||
| let expected_sdk_sse = match sse_type { | ||
| None => aws_sdk_s3::types::ServerSideEncryption::Aes256, | ||
| Some("AES256") => aws_sdk_s3::types::ServerSideEncryption::Aes256, |
There was a problem hiding this comment.
I think, aws_sdk_s3::types::ServerSideEncryption implements From<&str>
| @@ -300,6 +300,12 @@ pub struct HeadObjectResult { | |||
| /// HeadObject must explicitly request for this field to be included, | |||
| /// otherwise the values will be empty. | |||
| pub checksum: Checksum, | |||
|
|
|||
| /// Server-side encryption type that was used to store the object. | |||
| pub sse_type: Option<String>, | |||
There was a problem hiding this comment.
do we expect this to be set for all objects? I think, Option<String> in the client is fine, but in mountpoint code, what are we going to do if it is not set? (and what assumptions do we make about the state of such object)
There was a problem hiding this comment.
This is not currently used in Mountpoint.
|
|
||
| /// See [Server-side encryption](https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-express-data-protection.html#s3-express-ecnryption) for directory buckets. | ||
| #[test_case(None, None)] | ||
| #[test_case(Some("AES256"), None)] |
There was a problem hiding this comment.
are those cases actually different from the HeadObject perspective?
There was a problem hiding this comment.
You are right. Remove and explained the limitation on directory bucket tests. If we want to expand them in the future, we'll need to configure a different bucket in the CI.
Signed-off-by: Alessandro Passaro <[email protected]>
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add two new fields to
HeadObjectResult:sse_type: The server-side encryption algorithm used to store the object (header: "x-amz-server-side-encryption"),sse_kms_key_id: The ID of the KMS key was used for object encryption, if present (header: "x-amz-server-side-encryption-aws-kms-key-id").Does this change impact existing behavior?
No. Only adds fields to a non-exhaustive type.
Does this change need a changelog entry in any of the crates?
Yes:
mountpoint-s3-client.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).