Avoid extending part on backward seek #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we combine parts from the seek window to `current_part` in the part queue whenever we seek backward which mean we also have to re-compute checksums for this combined part. It particularly affect read throughput in some use cases where backward seek rate is high. This change should improve the throughput for those use cases. Signed-off-by: Monthon Klongklaew <[email protected]>
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
reviewed
Sep 9, 2024
monthonk
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
reviewed
Sep 9, 2024
Signed-off-by: Monthon Klongklaew <[email protected]>
monthonk
force-pushed
the
fix_perf_regression
branch
from
11d391b
to
f020827
Compare
monthonk
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Currently, we combine parts from the seek window to
current_partin the part queue whenever we seek backward which mean we also have to re-compute checksums for this combined part. It particularly affect read throughput in some use cases where backward seek rate is high. This change should improve the throughput for those use cases.Does this change impact existing behavior?
No
Does this change need a changelog entry in any of the crates?
No, this is a performance improvement change
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).