Skip to content

Commit

Permalink
Remove clone of current span in record_name fn (#1045)
Browse files Browse the repository at this point in the history
Signed-off-by: Daniel Carl Jones <[email protected]>
  • Loading branch information
dannycjones authored Oct 1, 2024
1 parent 3d76e07 commit e95560b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions mountpoint-s3/src/logging.rs
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,6 @@ fn init_tracing_subscriber(config: LoggingConfig) -> anyhow::Result<()> {
Ok(())
}

pub fn record_name(name: &str) -> Span {
Span::current().record("name", name).clone()
pub fn record_name(name: &str) {
Span::current().record("name", name);
}

2 comments on commit e95560b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: e95560b Previous: 4e99e79 Ratio
seq_read_direct 23907.32421875 MiB 3588.703125 MiB 6.66

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: e95560b Previous: 4e99e79 Ratio
seq_read_direct 22872.30078125 MiB 3588.703125 MiB 6.37

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.