Add From and TryFrom for MlsTime
#281
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just aligns better with the existing `From<u64>` conversion.
|
Just a few conversions I found I needed while working with certificate validation. |
tomleavy
approved these changes
May 16, 2025
stefunctional
approved these changes
May 16, 2025
|
Thanks for the review! Will you be able to fix the new unrelated warnings? Closing and re-opening the PR should be enough to create a new test run against the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds two simple conversions for
MlsTime:From<Duration>andTryFrom<SystemTime>.Call-outs:
The existing
from_duration_since_epochcould be removed or marked deprecated in preparation for the 1.0 release.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.