feat(WASM): add nodejs webcrypto provider through feature gate #189
Conversation
nicdard
force-pushed
the
provider-crypto-node
branch
from
77e85be to
559a7c1
Compare
nicdard
changed the title
nicdard
changed the title
| @@ -0,0 +1,5 @@ | |||
| const crypto = require("node:crypto"); | |||
There was a problem hiding this comment.
Does node:crypto have the exact same api as subtle crypto?
There was a problem hiding this comment.
The Rust code is accessing the subtle object from this crypto object we bind. As I substituted the call to
window.crypto only.
However, I was re-checking the documentation and saw that the correct way is to use:
| const crypto = require("node:crypto"); | |
| const crypto = require("node:crypto").webcrypto; |
I'll test this and change accordingly
There was a problem hiding this comment.
it works, pushed the change, thanks!
mls-rs-core/Cargo.toml
Outdated
| @@ -23,6 +25,7 @@ serde = ["dep:serde", "zeroize/serde", "hex/serde", "dep:serde_bytes"] | |||
| last_resort_key_package_ext = [] | |||
|
|
|||
| [dependencies] | |||
| cfg-if = "1.0.0" | |||
There was a problem hiding this comment.
this doesn't seem to be used?
There was a problem hiding this comment.
sorry probably left there by mistake
mls-rs-core/Cargo.toml
Outdated
| web = [] | ||
| node = [] | ||
| default = ["std", "rfc_compliant", "fast_serialize", "web"] |
There was a problem hiding this comment.
I don't think this is needed because it is covered in mls-rs-crypto-webcrypto
There was a problem hiding this comment.
are you referring to this: https://doc.rust-lang.org/cargo/reference/features.html#feature-unification ?
There was a problem hiding this comment.
cool thanks for pointing out, this helped me with finding a good solution :)
mls-rs-core/src/time.rs
Outdated
| #[cfg(all(target_arch = "wasm32", feature = "node"))] | ||
| #[wasm_bindgen(inline_js = r#" | ||
| module.exports.date_now = function() { | ||
| return Date.now(); | ||
| };"#)] | ||
| extern "C" { | ||
| fn date_now() -> f64; | ||
| } | ||
|
|
There was a problem hiding this comment.
Does this mean that I can't compile this for wasm32 with --no-default-features (since date_now is undefined) or --all-features (since date_now is defined twice)? I think in rust features should be additive. Maybe something like not(feature = "web") here? Not sure
There was a problem hiding this comment.
oh ok I see, I will try to make them additive, thanks!
There was a problem hiding this comment.
I think I have implemented a good solution now, where I only add a new feature node.
Thanks! sure I will share later on when I have the thesis ready if you are interested :) |
nicdard
force-pushed
the
provider-crypto-node
branch
from
605891f to
d792356
Compare
nicdard
force-pushed
the
provider-crypto-node
branch
from
838b066 to
ebf2c83
Compare
nicdard
force-pushed
the
provider-crypto-node
branch
from
ebf2c83 to
3e27f05
Compare
|
@mulmarta @tomleavy I found another compatibility issue with NodeJS: While Chrome generates the public key from a EC private key when importing it fro pkcs8 format, NodeJs doesn't, therefore an empty commit or an update proposal would fail. I am importing the key in jwk to force the generation of the public key part. The same issue is also present in safari and firefox, with the difference that those are throwing an exception already when you try to import a pkcs8 key as a CryptoKey if it contains only the secret key bytes, so the workaround for Node cannot be applied there. |
Issues:
Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2
Description of changes:
As NodeJs is implementing the WebCrypto API specification, adding the possibility to conditionally compile the webcrypto provider for NodeJs environment.
This can be useful to enhance interoperability.
In my case specifically, I need to have a node compatible provider to simplify testing and benchmarking my application using this library compiled to WASM.
Call-outs:
I am still a beginner in Rust and WASM
Testing:
This change is currently used in my master thesis project (@mulmarta we contacted you a while ago, David Balbás wrote you an email to ask around exporting the epoch secret).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.