Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix the type error in example Notebook 2 #886

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

zhjwy9343
Copy link
Contributor

Issue #, if available:

Description of changes:
This PR fix the type error of reverse_edge_types_map in the API example notebook 2. When it should be a dictionary. When set the exclude_training_targets to be True, this map will be used.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zhjwy9343 zhjwy9343 added documentation Improvements or additions to documentation 0.3 ready able to trigger the CI labels Jun 20, 2024
Copy link
Contributor

@classicsong classicsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhjwy9343 zhjwy9343 merged commit 63d3051 into awslabs:main Jun 20, 2024
1 check passed
jalencato pushed a commit that referenced this pull request Jun 20, 2024
*Issue #, if available:*

*Description of changes:*
This PR fix the type error of `reverse_edge_types_map` in the API
example notebook 2. When it should be a dictionary. When set the
`exclude_training_targets` to be `True`, this map will be used.

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

Co-authored-by: Ubuntu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.3 documentation Improvements or additions to documentation ready able to trigger the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants