-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docker] Update DGL version to 2.3 and torch to 2.3 #883
Conversation
What's the error we're getting here? Was numpy 2.x just released? |
Currently the our docker container will install some wrong version sub-dependencies. Like pyarrow & numpy. The default numpy version in the container now is 2.0, which will throw a warning:
Also check the issue here: #884, starting from 2.2, dgl stores its dependencies in a new place Currently this PR is holding for waiting the regression performance. I want to make sure all the performance works good before asking for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update:
The bug only happens during torch version < 2.3, we may not change the Dockerfile now, but only leaves a comment about it.
We should try to pin the numpy to version In the future we can look to create generate requirements files from a pyproject.toml, either using |
Issue #, if available:
Description of changes:
Fix the dependency version in local docker container
Torch 2.0+ does not support numpy >= 2.0 as we are using numpy.int64 in infer type.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.