Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix the case when the input value of wd_l2norm is using scientific notation. #1054

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

classicsong
Copy link
Contributor

@classicsong classicsong commented Oct 1, 2024

Issue #, if available:
#1051

Description of changes:
Fix the bug for wd_l2norm and alpha_l2norm

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@classicsong classicsong added ready able to trigger the CI 0.4 labels Oct 1, 2024
Copy link
Collaborator

@Oxfordblue7 Oxfordblue7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@classicsong classicsong merged commit 2fd1511 into awslabs:main Oct 2, 2024
8 checks passed
@classicsong classicsong deleted the fix-wd-l2norm branch October 2, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.4 ready able to trigger the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants