Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Doc Link Fix for GSProcessing #1038

Merged
merged 11 commits into from
Oct 1, 2024
Merged

Conversation

jalencato
Copy link
Collaborator

@jalencato jalencato commented Sep 24, 2024

Issue #, if available:

Description of changes:
Preview page: https://jalencato-graphstorm-doc-2.readthedocs.io/en/latest/cli/graph-construction/distributed/gsprocessing/aws-infra/amazon-sagemaker.html

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jalencato jalencato marked this pull request as ready for review September 24, 2024 18:34
@thvasilo
Copy link
Contributor

Have we checked that the links render correctly when used this way? Could also use a :ref: or :doc: directive right?

@jalencato
Copy link
Collaborator Author

Have we checked that the links render correctly when used this way? Could also use a :ref: or :doc: directive right?

I'd like to but my readmydoc seems to meet some problems to render the page, so I have not raised this PR for review.

Copy link
Contributor

@zhjwy9343 zhjwy9343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jalencato jalencato merged commit 0b48f4e into awslabs:main Oct 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants