Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

feat(schema): Support condition properties in resources #459

Merged
merged 1 commit into from
May 3, 2022

Conversation

jpinkney-aws
Copy link
Contributor

Issue #, if available:
Related aws-toolkit-vscode issue: aws/aws-toolkit-vscode#1978

Description of changes:
This PR adds in support for condition properties in resources, essentially allowing something like:

Resources:
  MountPoint:
    Type: "AWS::EC2::VolumeAttachment"
    Condition: CreateProdResources
    Properties:
      InstanceId: !Ref EC2Instance
      VolumeId: !Ref NewVolume
      Device: /dev/sdh

from the aws documentation to be valid in JSON.

The above example was taken from: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/conditions-sample-templates.html

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rubenfonseca rubenfonseca merged commit b3b7397 into awslabs:master May 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022

🎉 This PR is included in version 6.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants