This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
feat(schema): Support custom resource types #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for the help adding custom resources! |
|
🎉 This PR is included in version 6.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Related issue in aws-toolkit-vscode: aws/aws-toolkit-vscode#1978
Description of changes:
This PR adds in support for custom resources in the format of
Custom::MyCustomResourceTypeNameas shown in the docs. From what I can tell, the unmarshalling of the Custom resource is already supported on the golang side in https://github.com/awslabs/goformation/blob/master/cloudformation/template.go#L125 so this just changes the JSON schemas.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.