Drop Python 3.8 from workflows, run on 3.11 #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c95d386.
lostella
force-pushed
the
test-on-311-312
branch
from
879a304 to
b572b57
Compare
lostella
changed the title
lostella
requested review from
abdulfatir and
canerturkmen
and removed request for
shchur and
abdulfatir
canerturkmen
reviewed
Nov 5, 2024
| @@ -50,7 +50,7 @@ def test_custom_neg_bin_cdf(total_count, probs, value): | |||
| @pytest.mark.parametrize("probs", [0.1, 0.5, 0.8]) | |||
| @pytest.mark.parametrize("total_count", [3, 7, 100]) | |||
| @pytest.mark.parametrize("value", [0.1, 0.5, 0.9]) | |||
| def test_custom_neg_bin_icdf(total_count, probs, value): | |||
| def test_custom_studentt_icdf(total_count, probs, value): | |||
There was a problem hiding this comment.
why studentt? (the function body refers to NegBin still.
There was a problem hiding this comment.
ha! rebasing issue I suppose
.github/workflows/tests-prophet.yaml
Outdated
| @@ -8,7 +8,7 @@ jobs: | |||
| max-parallel: 4 | |||
| fail-fast: false | |||
| matrix: | |||
| python-version: ['3.8'] | |||
| python-version: ['3.12'] | |||
There was a problem hiding this comment.
prophet itself only appears to support until 3.11
https://github.com/facebook/prophet/blob/main/python/pyproject.toml
.github/workflows/tests-r.yml
Outdated
| @@ -8,7 +8,7 @@ jobs: | |||
| max-parallel: 4 | |||
| fail-fast: false | |||
| matrix: | |||
| python-version: ['3.9'] | |||
| python-version: ['3.12'] | |||
There was a problem hiding this comment.
why 3.12 in some places and 3.11 in others? should 3.11 be our standard latest especially in extras?
There was a problem hiding this comment.
I think that makes sense, updating
lostella
changed the title
lostella
commented
Nov 5, 2024
Comment on lines
-23
to
-25
| context_length: int = serde.OrElse( | ||
| lambda prediction_length: prediction_length * 2 | ||
| ) |
There was a problem hiding this comment.
Python 3.11 would complain here, that the default value in a dataclass cannot be mutable
lostella
commented
Nov 5, 2024
| @@ -30,7 +30,7 @@ | |||
|
|
|||
| try: | |||
| import mxnet as mx | |||
| except ImportError: | |||
There was a problem hiding this comment.
The import above can raise OSError as well, so I'm catching that too to turn off mx
canerturkmen
approved these changes
Nov 5, 2024
|
|
||
| use_feat_static_cat: bool = True | ||
| cardinality: List[int] = serde.EVENTUAL | ||
|
|
||
| def __eventually__(self, cardinality): | ||
| def __eventually__(self, context_length, cardinality): |
lostella
added
the
pending v0.16.x backport
lostella
added a commit
to lostella/gluonts
that referenced
this pull request
Nov 7, 2024
*Issue #, if available:* Python 3.8 reached EOL, and some packages are not distributed for it in their latest versions. *Description of changes:* - update github workflows to run on Python (up to) 3.11 - fix tests and testutils that would break on 3.11 - delete some unused workflows - update sphinx version used in the docs build workflow By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. **Please tag this pr with at least one of these labels to make our release process faster:** BREAKING, new feature, bug fix, other change, dev setup
Merged
lostella
added a commit
that referenced
this pull request
Nov 7, 2024
*Description of changes:* Backporting PRs - #3228 - #3232 - #3233 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. **Please tag this pr with at least one of these labels to make our release process faster:** BREAKING, new feature, bug fix, other change, dev setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Python 3.8 reached EOL, and some packages are not distributed for it in their latest versions.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup