address comment

awslabs · May 27, 2024 · fb1049f · fb1049f
1 parent fcdaf04
commit fb1049f
Showing 1 changed file with 5 additions and 14 deletions.
diff --git a/test/ext/r_forecast/test_r_univariate_predictor.py b/test/ext/r_forecast/test_r_univariate_predictor.py
@@ -36,20 +36,7 @@
 TOLERANCE = 1e-6
 
 
-@pytest.mark.parametrize(
-    "method_name",
-    [
-        (
-            method_name
-            if method_name != "fourier.arima.xreg"
-            else pytest.param(
-                "fourier.arima.xreg",
-                marks=pytest.mark.xfail(reason="Known bug"),
-            )
-        )
-        for method_name in SUPPORTED_UNIVARIATE_METHODS
-    ],
-)
+@pytest.mark.parametrize("method_name", SUPPORTED_UNIVARIATE_METHODS)
 def test_forecasts(method_name):
     if method_name == "mlp":
         # https://stackoverflow.com/questions/56254321/error-in-ifncol-matrix-rep-argument-is-of-length-zero
@@ -61,6 +48,10 @@ def test_forecasts(method_name):
             "MLP currently does not work because "
             "the `neuralnet` package is not yet updated with a known bug fix in ` bips-hb/neuralnet`"
         )
+    if method_name == "fourier.arima.xreg":
+        pytest.xfail(
+            "Method `fourier.arima.xreg` does not work because of a known issue."
+        )
 
     dataset = datasets.get_dataset("constant")