Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use node 22 #904

Merged
merged 3 commits into from
Jan 24, 2025
Merged

feat: use node 22 #904

merged 3 commits into from
Jan 24, 2025

Conversation

scottschreckengaust
Copy link
Collaborator

@scottschreckengaust scottschreckengaust commented Jan 23, 2025

Signed-off-by: Scott Schreckengaust [email protected]

Fixes #902


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Signed-off-by: Scott Schreckengaust <[email protected]>
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (f32b386) to head (8f273c0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #904    +/-   ##
========================================
  Coverage   95.57%   95.57%            
========================================
  Files          66       66            
  Lines       21653    21653            
  Branches      668      443   -225     
========================================
  Hits        20695    20695            
  Misses        958      958            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MichaelWalker-git MichaelWalker-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@krokoko krokoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting on hold as testing #899 and would like to include the fix in next release. Will approve right after

@krokoko krokoko self-requested a review January 24, 2025 20:11
@scottschreckengaust scottschreckengaust merged commit bef92fb into main Jan 24, 2025
20 checks passed
@scottschreckengaust scottschreckengaust deleted the feature/use-node22 branch January 24, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support NodeJS >=20
4 participants