Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(construct): merged amazon aurora vector stores #418

Closed
wants to merge 0 commits into from

Conversation

maxtybar
Copy link
Contributor

@maxtybar maxtybar commented May 2, 2024

Fixes #373

  1. Merged AmazonAuroraDefaultVectorStore into AmazonAuroraVectorStore resulting in a single construct that customer needs to import.
  2. Created fromExistingAuroraVectorStore in AmazonAuroraVectorStore construct so customers could import values from an existing Aurora database.
  3. Refactored models and moved it outside of bedrock construct in a dedicated foudnationsmodels construct. This results in elimination of potential cross-reference issues in the future where a knowledge base vector is consuming models but is also being referenced within bedrock construct.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.61%. Comparing base (d2966fb) to head (62df1b2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
+ Coverage   93.14%   93.61%   +0.46%     
==========================================
  Files          50       51       +1     
  Lines       11365    11614     +249     
  Branches      251      361     +110     
==========================================
+ Hits        10586    10872     +286     
+ Misses        779      742      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(amazonaurora): merge amazon aurora vector stores
2 participants