Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Resolves #74
Problem
The current extraction logic has a bug where it sometimes emits multiple requirement statements for the same text. It mostly comes down to two different scenarios:
Duplicate text
Sometimes a requirement sentence can appear multiple times in a single section.
Compound requirement
Sometimes a requirement can appear in the same sentence as another:
Previously the
report
command "accidentally" deduplicated these strings when generating the report, since it was using aBTreeSet<Annotation>
. With the recent refactors that added line numbers to theAnnotation
struct, these are no longer considered equivalent.Solution
This change deduplicates requirements at the extract phase by normalizing the text and checking if it's already been mentioned as a requirement. If it has, then it skips emitting it a second time.
Note that even with this change we still have the gaps described in #159 and #161. Solutions for those will come separately.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.