fix!: Make config object immutable after client creation #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
commented
Feb 6, 2025
| @@ -19,7 +20,7 @@ class EndpointPlugin(private val serviceConfig: ServiceConfig) : Plugin { | |||
| } | |||
|
|
|||
| override fun render(ctx: ProtocolGenerator.GenerationContext, writer: SwiftWriter) { | |||
| writer.openBlock("public class $pluginName: Plugin {", "}") { | |||
| writer.openBlock("public class \$L: \$N {", "}", pluginName, ClientRuntimeTypes.Core.Plugin) { | |||
There was a problem hiding this comment.
Cleanup, and used the symbol for Plugin to ensure correct imports.
jbelkins
commented
Feb 6, 2025
| "}", | ||
| serviceConfig.typeName, | ||
| ) { | ||
| writer.write("clientConfiguration.endpointResolver = self.endpointResolver") |
There was a problem hiding this comment.
Safe unwrap is unneeded & removed.
jbelkins
commented
Feb 6, 2025
| "clientConfiguration.bearerTokenIdentityResolver = \$N(token: \$N(token: \"\"))", | ||
| SmithyIdentityTypes.StaticBearerTokenIdentityResolver, | ||
| SmithyIdentityTypes.BearerTokenIdentity | ||
| ) |
There was a problem hiding this comment.
Safe unwrap is unneeded & removed. Also a little code cleanup.
jbelkins
commented
Feb 6, 2025
| writer.write("clientConfiguration.awsCredentialIdentityResolver = self.awsCredentialIdentityResolver!") | ||
| } | ||
| writer.openBlock("if self.bearerTokenIdentityResolver != nil {", "}") { | ||
| writer.write("clientConfiguration.bearerTokenIdentityResolver = self.bearerTokenIdentityResolver!") |
There was a problem hiding this comment.
Safe unwrap is unneeded & removed. Also cleanup.
jbelkins
commented
Feb 6, 2025
| @@ -129,7 +129,7 @@ class AWSHttpProtocolServiceClient( | |||
| */ | |||
| private fun renderRegionConfigInitializer(properties: List<ConfigProperty>) { | |||
| writer.openBlock( | |||
| "public convenience init(region: \$N) throws {", | |||
| "public init(region: \$N) throws {", | |||
There was a problem hiding this comment.
Removed convenience since config is no longer a class.
jbelkins
commented
Feb 6, 2025
| } | ||
| public func configureClient(clientConfiguration: inout Config) { | ||
| clientConfiguration.region = self.region | ||
| clientConfiguration.signingRegion = self.region |
There was a problem hiding this comment.
Safe unwrap is unneeded & removed.
jbelkins
commented
Feb 6, 2025
| clientConfiguration.awsRetryMode, | ||
| clientConfiguration.maxAttempts | ||
| ) | ||
| clientConfiguration.awsCredentialIdentityResolver = try AWSClientConfigDefaultsProvider.awsCredentialIdentityResolver() |
There was a problem hiding this comment.
Safe unwrap is unneeded & removed.
jbelkins
commented
Feb 6, 2025
| public protocol AWSRegionClientConfiguration { | ||
| import protocol ClientRuntime.ClientConfiguration | ||
|
|
||
| public protocol AWSRegionClientConfiguration: ClientConfiguration { |
There was a problem hiding this comment.
Adding this conformance here since it is already always true, and it removes the need to specify it in the region config plugin below.
…into jbe/plugin_revamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.