Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: fix docs accessibility #1374

Merged
merged 4 commits into from
Jul 31, 2024
Merged

misc: fix docs accessibility #1374

merged 4 commits into from
Jul 31, 2024

Conversation

lauzadis
Copy link
Member

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

sonarcloud bot commented Jul 30, 2024

Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

@lauzadis lauzadis added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Jul 31, 2024
Copy link

Affected Artifacts

No artifacts changed size

@lauzadis lauzadis marked this pull request as ready for review July 31, 2024 15:11
@lauzadis lauzadis requested a review from a team as a code owner July 31, 2024 15:11
Comment on lines +59 to +62
.keyValue {
display: block;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: where is this used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be in this PR as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for catching it

@lauzadis lauzadis merged commit deb55d9 into main Jul 31, 2024
20 of 22 checks passed
@lauzadis lauzadis deleted the misc-docs-accessibility branch July 31, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants