Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: correct test assertion and @Ignore it #1239

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

lauzadis
Copy link
Member

@lauzadis lauzadis commented Mar 1, 2024

The previous assertion for X-Amz-Security-Token is not consistently working across all developer environments. That header is only added by some credentials providers, so it's not a safe assertion to make.

This PR updates the test to the "correct" state and adds @Ignore until #1236 is resolved.

Issue #

Description of changes

This change is required to ensure E2E tests pass on all developer environments

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lauzadis lauzadis added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

A new generated diff is ready to view.

@lauzadis lauzadis marked this pull request as ready for review March 1, 2024 14:56
@lauzadis lauzadis requested a review from a team as a code owner March 1, 2024 14:56
@lauzadis lauzadis merged commit 95386d3 into main Mar 1, 2024
17 of 18 checks passed
@lauzadis lauzadis deleted the misc-ignore-test branch March 1, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants