chore: add @InternalSdkApi to binary compatibility checks; introduce new PR check to verify no API-breaking changes #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new PR check to verify no API-breaking changes
ianbotsf
added
the
no-changelog
|
lauzadis
approved these changes
Feb 6, 2024
|
A new generated diff is ready to view.
|
0marperez
approved these changes
Feb 6, 2024
aajtodd
approved these changes
Feb 6, 2024
| branches: [ main ] | ||
|
|
||
| jobs: | ||
| api-compat-verification: |
There was a problem hiding this comment.
suggestion: We could move this to workflow to aws-kotlin-repo-tools and share it across repos. It's not a lot of code and not likely to change often but something to consider if we do end up having to make changes to each repo over time.
There was a problem hiding this comment.
Yes but I'd rather do that in a separate effort. I think a few of our GH workflows are candidates for consolidation which would warrant a new PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Resolves #1191
Description of changes
Same as smithy-lang/smithy-kotlin#1030 but for aws-sdk-kotlin:
@InternalSdkApifrom the exemptions for the backwards compatibility verifierBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.