Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presigned requests only support SigV4 #1236

Open
lauzadis opened this issue Feb 28, 2024 · 0 comments
Open

Presigned requests only support SigV4 #1236

lauzadis opened this issue Feb 28, 2024 · 0 comments
Labels
bug This issue is a bug. p2 This is a standard priority issue

Comments

@lauzadis
Copy link
Member

Describe the bug

Presigners assume the request is always presigned with SigV4. This means alternate auth schemes (like SigV4a, SigV4S3Express) cannot be used for presigning.

Expected behavior

A presigned request should use whichever auth scheme would be used when making the normal, non-presigned request (i.e, the auth scheme resolved from endpoint rules).

Current behavior

The presigner uses SigV4

Steps to Reproduce

Make a presigned request which would normally result in SigV4a or SigV4S3Express being used. Observe that SigV4 is used instead.

Possible Solution

The relevant section is here: https://github.com/awslabs/smithy-kotlin/blob/main/runtime/auth/aws-signing-common/common/src/aws/smithy/kotlin/runtime/auth/awssigning/Presigner.kt#L37

It will likely require another overhaul of the presigner, since the last refactor was done before the auth refactor.

Context

No response

AWS Kotlin SDK version used

1.0.66

Platform (JVM/JS/Native)

JVM

Operating System and version

macOS Sonoma

@lauzadis lauzadis added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. and removed needs-triage This issue or PR still needs to be triaged. labels Feb 28, 2024
@ianbotsf ianbotsf added the p2 This is a standard priority issue label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

2 participants