-
Notifications
You must be signed in to change notification settings - Fork 360
fix(docs): examples/extension-internal-flush: don't refer to a standalone layer arn for internal extension #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Actually, this isn't working properly in my local testing. I think the original command was wrong. I'll open a new one later. |
Reopening, my issues testing locally seem to be due to a bug in This was actually called out when this example was first added: The commands work fine as written:
which returns:
And then AWS logs show the extension running in-process:
|
Have a fix up for the This example does successfully run locally with that fix in place. |
959e418
to
900bf88
Compare
I went ahead and added in:
|
As another side note, I'd like to update the example to show a more realistic per-event flush via an extension using a non-blocking writer, if I implement this feature in (that's assuming this change lands: #982) |
…lone layer arn for internal extension deploy, add testing information
📬 Issue #, if available:
n/a
✍️ Description of changes:
Small tweak to the docs for our example on internal extensions. We currently refer to retrieving a layer arn from
cargo lambda deploy
. This was probably copy-pasted from other examples where we actually are callingcargo lambda deploy
with the--extension
target.In this case, we are deploying the function directly, and there is no standalone extension - it is all inside our primary binary.
Tweaking the language to remove a reference to a deployed layer ARN.
If we want to add a guide to invoking the remote function deployment, we could. The other examples don't have that though.
🔏 By submitting this pull request
cargo +nightly fmt
.cargo clippy --fix
.