Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clippy error + bump MSRV #948

Merged
merged 5 commits into from
Dec 9, 2024
Merged

fix: clippy error + bump MSRV #948

merged 5 commits into from
Dec 9, 2024

Conversation

maxday
Copy link
Contributor

@maxday maxday commented Dec 5, 2024 •
edited
Loading

✍️ Description of changes:

It seems that the linter actions are not correctly run for every PRs, the paths defined were not enough to cover all use cases.
This PR:

  • Strengthen GitHub Actions path selector
  • Bump MSRV
  • Fix Cargo Clippy errors

🔏 By submitting this pull request

  • I confirm that I've ran cargo +nightly fmt.
  • I confirm that I've ran cargo clippy --fix.
  • I confirm that I've made a best effort attempt to update all relevant documentation.
  • I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maxday maxday requested a review from bnusunny December 5, 2024 17:04
bnusunny
bnusunny approved these changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@bnusunny bnusunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxday maxday merged commit f024fd0 into awslabs:main Dec 9, 2024
10 checks passed
@maxday maxday mentioned this pull request Dec 9, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnusunny bnusunny bnusunny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxday @bnusunny